Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2755953005: color: Use SkColorSpaceXform instead of QCMS for LUTs (Closed)

Created:
3 years, 9 months ago by ccameron
Modified:
3 years, 9 months ago
Reviewers:
msarett1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

color: Use SkColorSpaceXform instead of QCMS for LUTs Use SkColorSpaceXform to compute LUTs instead of using QCMS. This matches the behavior in Blink. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2755953005 Cr-Commit-Position: refs/heads/master@{#459622} Committed: https://chromium.googlesource.com/chromium/src/+/b3206e28268889e6dc83610c6711a1460a4cfde2

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : More clean up #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -146 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/color_space.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/color_transform.cc View 1 2 3 11 chunks +107 lines, -128 lines 0 comments Download
M ui/gfx/icc_profile.cc View 1 2 3 4 chunks +21 lines, -7 lines 0 comments Download
M ui/gfx/icc_profile_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
ccameron
After this, the only use of QCMS will be ash/display/display_color_manager_chromeos.cc Which, hopefully, we'll be able ...
3 years, 9 months ago (2017-03-17 23:05:12 UTC) #2
msarett1
lgtm
3 years, 9 months ago (2017-03-20 14:17:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755953005/40001
3 years, 9 months ago (2017-03-24 19:47:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/177232) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 19:51:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755953005/60001
3 years, 9 months ago (2017-03-25 01:02:35 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 02:10:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b3206e28268889e6dc83610c6711...

Powered by Google App Engine
This is Rietveld 408576698