Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: ui/gfx/icc_profile_unittest.cc

Issue 2755953005: color: Use SkColorSpaceXform instead of QCMS for LUTs (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/icc_profile.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/icc_profile_unittest.cc
diff --git a/ui/gfx/icc_profile_unittest.cc b/ui/gfx/icc_profile_unittest.cc
index 35d8edcffac2ae072a35b50fb008d811f967867f..ebf652ee9c450b0725878c4cd9c75e090f24a1a4 100644
--- a/ui/gfx/icc_profile_unittest.cc
+++ b/ui/gfx/icc_profile_unittest.cc
@@ -93,13 +93,11 @@ TEST(ICCProfile, ParametricVersusExact) {
&accurate_parametric_color_space));
EXPECT_EQ(accurate_parametric_color_space, accurate);
- // This ICC profile has only an A2B representation. For now, this means that
- // the parametric representation will be sRGB. We will eventually want to get
- // some sense of the gamut.
+ // This ICC profile has only an A2B representation. We cannot create an
+ // SkColorSpaceXform to A2B only ICC profiles, so this should be marked
+ // as invalid.
ICCProfile a2b = ICCProfileForTestingA2BOnly();
- EXPECT_TRUE(a2b.GetColorSpace().IsValid());
- EXPECT_NE(a2b.GetColorSpace(), a2b.GetParametricColorSpace());
- EXPECT_EQ(ColorSpace::CreateSRGB(), a2b.GetParametricColorSpace());
+ EXPECT_FALSE(a2b.GetColorSpace().IsValid());
}
TEST(ICCProfile, GarbageData) {
« no previous file with comments | « ui/gfx/icc_profile.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698