Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2753293003: gpu: Replace GpuMsg_CollectGraphicsInfo with mojom API. (Closed)

Created:
3 years, 9 months ago by sadrul
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Replace GpuMsg_CollectGraphicsInfo with mojom API. This introduces mojom.GpuService.RequestCompleteGpuInfo() API to replace the GpuMsg_CollectGraphicsInfo chrome ipc message. BUG=643746 Review-Url: https://codereview.chromium.org/2753293003 Cr-Commit-Position: refs/heads/master@{#459632} Committed: https://chromium.googlesource.com/chromium/src/+/9e029acf8a371e301aefcb51b4863137adccde68

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix win #

Patch Set 4 : tot merge #

Total comments: 3

Patch Set 5 : Run callback on UI thread. Tot merge. #

Patch Set 6 : . #

Patch Set 7 : test #

Patch Set 8 : . #

Patch Set 9 : debug test failure #

Patch Set 10 : debug test failure #

Patch Set 11 : . #

Patch Set 12 : fix telemetry test #

Patch Set 13 : tot merge #

Patch Set 14 : fix win build #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Patch Set 19 : . #

Patch Set 20 : . #

Patch Set 21 : cleanup #

Patch Set 22 : . #

Patch Set 23 : more #

Patch Set 24 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -98 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 4 7 9 12 13 14 15 16 17 18 19 20 21 2 chunks +21 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -23 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +0 lines, -8 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +0 lines, -57 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 3 chunks +4 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +57 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 114 (102 generated)
sadrul
tsepez@ for mojom and messages change. piman@ for all of it. Thanks!
3 years, 9 months ago (2017-03-20 00:00:14 UTC) #15
Tom Sepez
Messages/Mojom LGTM (equivalent functionality).
3 years, 9 months ago (2017-03-20 17:20:44 UTC) #20
piman
https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode433 content/browser/gpu/gpu_data_manager_impl_private.cc:433: GpuDataManagerImpl::GetInstance()->UpdateGpuInfo(gpu_info); Should we hop back to the UI thread, ...
3 years, 9 months ago (2017-03-20 21:02:36 UTC) #21
sadrul
https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode433 content/browser/gpu/gpu_data_manager_impl_private.cc:433: GpuDataManagerImpl::GetInstance()->UpdateGpuInfo(gpu_info); On 2017/03/20 21:02:36, piman wrote: > Should we ...
3 years, 9 months ago (2017-03-20 21:21:44 UTC) #24
piman
https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/2753293003/diff/50001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode433 content/browser/gpu/gpu_data_manager_impl_private.cc:433: GpuDataManagerImpl::GetInstance()->UpdateGpuInfo(gpu_info); On 2017/03/20 21:21:44, sadrul wrote: > On 2017/03/20 ...
3 years, 9 months ago (2017-03-20 21:33:54 UTC) #25
piman
lgtm
3 years, 9 months ago (2017-03-20 21:33:59 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753293003/70001
3 years, 9 months ago (2017-03-20 22:48:50 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/404219)
3 years, 9 months ago (2017-03-21 00:01:26 UTC) #31
sadrul
In case you are wondering what happened to this CL: it's causing some somewhat-flaky test ...
3 years, 9 months ago (2017-03-23 19:47:54 UTC) #74
sadrul
The flakiness seems to have gone away ... I will put it in the CQ ...
3 years, 9 months ago (2017-03-24 04:13:24 UTC) #93
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753293003/460001
3 years, 9 months ago (2017-03-25 02:45:02 UTC) #111
commit-bot: I haz the power
3 years, 9 months ago (2017-03-25 02:52:48 UTC) #114
Message was sent while issue was closed.
Committed patchset #24 (id:460001) as
https://chromium.googlesource.com/chromium/src/+/9e029acf8a371e301aefcb51b486...

Powered by Google App Engine
This is Rietveld 408576698