Issue 274773002: [telemetry] Prototype for specifying page sets using Python imports and Telemetry discovery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 274773002: [telemetry] Prototype for specifying page sets using Python imports and Telemetry discovery. (Closed)

Created:
6 years, 7 months ago by dtu

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, piman+watch_chromium.org, telemetry+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[telemetry] Prototype for specifying page sets using Python imports and Telemetry discovery. Removes all logic for creating a page set from a filename. Even at the command-line, you'd use the module name: - src$ tools/perf/run_measurement smoothness top_25 Instead of the previous: - src$ tools/perf/run_measurement smoothness page_sets/top_25.py BUG=362293, 239179

Patch Set 1 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+255 lines, -489 lines)			Patch
M	content/test/gpu/run_gpu_test.py	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	tools/perf/benchmarks/smoothness.py	View	14 chunks	+20 lines, -18 lines	0 comments	Download
M	tools/perf/measurements/measurement_unittest.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/perf/page_sets/__init__.py	View	1 chunk	+17 lines, -1 line	0 comments	Download
M	tools/perf/page_sets/page_set_unittest.py	View	2 chunks	+18 lines, -15 lines	0 comments	Download
A +	tools/perf/profile_creators/extensions_profile_creator.py	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/perf/profile_creators/many_extensions_profile_creator.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/perf/profile_creators/small_profile_creator.py	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	tools/perf/profile_creators/theme_profile_creator.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/perf/run_benchmark	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	tools/perf/run_measurement	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/core/backends/adb_commands.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/discover.py	View	2 chunks	+0 lines, -30 lines	0 comments	Download
M	tools/telemetry/telemetry/core/discover_unittest.py	View	2 chunks	+2 lines, -14 lines	0 comments	Download
D	tools/telemetry/telemetry/core/environment.py	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	tools/telemetry/telemetry/core/util.py	View	2 chunks	+0 lines, -9 lines	0 comments	Download
D	tools/telemetry/telemetry/page/extensions_profile_creator.py	View	1 chunk	+0 lines, -223 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_set.py	View	3 chunks	+11 lines, -33 lines	0 comments	Download
M	tools/telemetry/telemetry/page/page_set_unittest.py	View	2 chunks	+5 lines, -17 lines	0 comments	Download
M	tools/telemetry/telemetry/page/record_wpr.py	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/telemetry/telemetry/test.py	View	2 chunks	+18 lines, -5 lines	0 comments	Download
M	tools/telemetry/telemetry/test_runner.py	View	8 chunks	+118 lines, -47 lines	0 comments	Download
D	tools/telemetry/unittest_data/test_simple_one_page_set.py	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	tools/telemetry/unittest_data/test_simple_two_page_set.py	View	1 chunk	+0 lines, -13 lines	0 comments	Download