Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 274773002: [telemetry] Prototype for specifying page sets using Python imports and Telemetry discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_set_unittest.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index c8ba504c0af9dd6aebaa9cda4e022c0799043614..b1c03d5ec941fe670880bc54c05250490718688b 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -89,10 +89,14 @@ def Main(base_dir):
if not issubclass(cls, profile_creator.ProfileCreator)
}
tests = discover.DiscoverClasses(base_dir, base_dir, test.Test,
- index_by_class_name=True)
+ index_by_class_name=True).values()
+ tests = {test_class.Name(): test_class for test_class in tests}
+ page_sets = discover.DiscoverClasses(base_dir, base_dir, page_set.PageSet,
+ index_by_class_name=True).values()
+ page_sets = {ps.Name(): ps for ps in page_sets}
options = browser_options.BrowserFinderOptions()
- parser = options.CreateParser('%prog <PageSet|Test|URL>')
+ parser = options.CreateParser('%prog <PageSet|Test>')
page_runner.AddCommandLineArgs(parser)
recorder = RecordPage(measurements)
@@ -110,9 +114,9 @@ def Main(base_dir):
parser.parse_args()
recorder.test.ProcessCommandLineArgs(parser, options)
ps = tests[target]().CreatePageSet(options)
- elif discover.IsPageSetFile(target):
+ elif target in page_sets:
parser.parse_args()
- ps = page_set.PageSet.FromFile(target)
+ ps = tests[target]()
else:
parser.print_usage()
sys.exit(1)
« no previous file with comments | « tools/telemetry/telemetry/page/page_set_unittest.py ('k') | tools/telemetry/telemetry/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698