Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: tools/perf/measurements/measurement_unittest.py

Issue 274773002: [telemetry] Prototype for specifying page sets using Python imports and Telemetry discovery. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | tools/perf/page_sets/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/measurement_unittest.py
diff --git a/tools/perf/measurements/measurement_unittest.py b/tools/perf/measurements/measurement_unittest.py
index 8386be3ab71caaa4f0295c64f1129c365960a551..338ece76704acbbfc7b5c26a8c2264a03ec5ffbb 100644
--- a/tools/perf/measurements/measurement_unittest.py
+++ b/tools/perf/measurements/measurement_unittest.py
@@ -22,7 +22,7 @@ class MeasurementUnitTest(unittest.TestCase):
#
# Ideally this test would be comprehensive, but the above serves as a
# kind of smoke test.
- measurements_dir = os.path.dirname(__file__)
+ measurements_dir = os.path.dirname(os.path.realpath(__file__))
top_level_dir = os.path.dirname(measurements_dir)
benchmarks_dir = os.path.join(top_level_dir, 'benchmarks')
@@ -33,7 +33,7 @@ class MeasurementUnitTest(unittest.TestCase):
benchmarks_dir, top_level_dir, test.Test, pattern='*.py').values()
for benchmark in all_benchmarks:
- if benchmark.test not in all_measurements:
+ if benchmark.PageTestClass() not in all_measurements:
# If the benchmark is not in measurements, then it is not composable.
# Ideally we'd like to test these as well, but the non-composable
# benchmarks are usually long-running benchmarks.
« no previous file with comments | « tools/perf/benchmarks/smoothness.py ('k') | tools/perf/page_sets/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698