Instant Apps: refactor logic to encapsulate in the Instant Apps Handler.

Instant Apps: refactor logic to encapsulate in the Instant Apps Handler.

BUG=672238
Review-Url: https://codereview.chromium.org/2727483002
Cr-Commit-Position: refs/heads/master@{#454004}
Committed: https://chromium.googlesource.com/chromium/src/+/8efcc9367891485c350162f2224e8b93e349c291

[Maria, 2017-03-01 00:27:35]

The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run

[Maria, 2017-03-01 00:27:46]

mariakhomenko@chromium.org changed reviewers:
+ tedchoc@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:40:33]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Maria, 2017-03-01 04:51:02]

The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 04:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:34:29]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-03-01 16:55:51]

lgtm

https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:102:
private static final String[] SUPERVISOR_START_ACTIONS = {
I've vote to make the other ones public and marked @VisibleForTesting instead of
copying them here.

[Maria, 2017-03-01 17:43:39]

https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
(right):

https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:102:
private static final String[] SUPERVISOR_START_ACTIONS = {
On 2017/03/01 16:55:51, Ted C wrote:
> I've vote to make the other ones public and marked @VisibleForTesting instead
of
> copying them here.

That's what I did in patch 1. Turns out it's a findbugs error to have a public
static final mutable container (array). That's why I copied them here. The error
didn't show up before because they were package protected and findbugs only
complains about public exposure.

[Ted C, 2017-03-01 17:58:21]

On 2017/03/01 17:43:39, Maria wrote:
>
https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
> (right):
> 
>
https://codereview.chromium.org/2727483002/diff/20001/chrome/android/javatest...
>
chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java:102:
> private static final String[] SUPERVISOR_START_ACTIONS = {
> On 2017/03/01 16:55:51, Ted C wrote:
> > I've vote to make the other ones public and marked @VisibleForTesting
instead
> of
> > copying them here.
> 
> That's what I did in patch 1. Turns out it's a findbugs error to have a public
> static final mutable container (array). That's why I copied them here. The
error
> didn't show up before because they were package protected and findbugs only
> complains about public exposure.

Ah yes...I hit that recently as well...okee

[Maria, 2017-03-01 19:39:10]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2017-03-01 19:39:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 19:52:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488397150266010,
"parent_rev": "f8d2f9e953c38a7e1040e49cba9fb490f00f3844", "commit_rev":
"8efcc9367891485c350162f2224e8b93e349c291"}

[commit-bot: I haz the power, 2017-03-01 19:53:24]

Description was changed from

==========
Instant Apps: refactor logic to encapsulate in the Instant Apps Handler.

BUG=672238
==========

to

==========
Instant Apps: refactor logic to encapsulate in the Instant Apps Handler.

BUG=672238

Review-Url: https://codereview.chromium.org/2727483002
Cr-Commit-Position: refs/heads/master@{#454004}
Committed:
https://chromium.googlesource.com/chromium/src/+/8efcc9367891485c350162f2224e...
==========

[commit-bot: I haz the power, 2017-03-01 19:53:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8efcc9367891485c350162f2224e...