Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2727483002: Instant Apps: refactor logic to encapsulate in the Instant Apps Handler. (Closed)
Patch Set: Fix findbugs issue. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 97ecaa13004f1069f591f2b5afd71e061c2417ee..f94af5b492caeb797aa1f7468366dff4173b5f59 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -99,6 +99,10 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
private static final String COUNTERFEIT_WEBAPK_PACKAGE_NAME =
"org.chromium.webapk.counterfeit";
+ private static final String[] SUPERVISOR_START_ACTIONS = {
Ted C 2017/03/01 16:55:51 I've vote to make the other ones public and marked
Maria 2017/03/01 17:43:39 That's what I did in patch 1. Turns out it's a fin
+ "com.google.android.instantapps.START", "com.google.android.instantapps.nmr1.INSTALL",
+ "com.google.android.instantapps.nmr1.VIEW"};
+
private final TestExternalNavigationDelegate mDelegate;
private ExternalNavigationHandler mUrlHandler;
@@ -623,7 +627,7 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
InstantAppsHandler.IS_GOOGLE_SEARCH_REFERRER));
// Check that Supervisor is detected by action even without package
- for (String action : ExternalNavigationHandler.SUPERVISOR_START_ACTIONS) {
+ for (String action : SUPERVISOR_START_ACTIONS) {
String intentWithoutPackage = "intent://buzzfeed.com/tasty#Intent;scheme=http;"
+ "action=" + action + ";"
+ "S.com.google.android.instantapps.FALLBACK_PACKAGE="
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698