Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2725743002: Remove TabTest from tab_model_unittest.mm. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TabTest from tab_model_unittest.mm. Remove the test-only sub-class of Tab named TabTest from the tab_model_unittest.mm as it is not required (the test pass if using a regular Tab). BUG=620465 Review-Url: https://codereview.chromium.org/2725743002 Cr-Commit-Position: refs/heads/master@{#453954} Committed: https://chromium.googlesource.com/chromium/src/+/24efce85d5453d3cd42d8dbdf4479a3efdeeae18

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -40 lines) Patch
M ios/chrome/browser/tabs/tab_model_unittest.mm View 2 chunks +4 lines, -40 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-02-28 23:10:47 UTC) #3
Eugene But (OOO till 7-30)
lgtm
3 years, 9 months ago (2017-02-28 23:25:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725743002/20001
3 years, 9 months ago (2017-03-01 16:32:57 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 16:50:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/24efce85d5453d3cd42d8dbdf447...

Powered by Google App Engine
This is Rietveld 408576698