Convert TabModelTest to use the public API of TabModel.

Convert TabModelTest to use the public API of TabModel.

Give a unique window name to all the inserted Tabs and disable web
usage on the TabModel. With those changes it is possible to restrict
TabModelTest to use the public API of TabModel.

Using the public API makes it easier to refactor the code (as there
is no dependency on the implementation or hole into it from the test).

BUG=687207
Review-Url: https://codereview.chromium.org/2715753002
Cr-Commit-Position: refs/heads/master@{#454345}
Committed: https://chromium.googlesource.com/chromium/src/+/8dd0cb3cdf573d6ea0021f2962ef8116c9e80857

[sdefresne, 2017-02-23 18:14:34]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-02-23 18:14:35]

All the tests pass with this change. This make the test a bit more verbose but
avoid creating a hole in the TabModel API.

WDYT?

[sdefresne, 2017-03-02 03:20:04]

rohitrao: ping

[sdefresne, 2017-03-02 04:50:45]

Patchset #2 (id:20001) has been deleted

[sdefresne, 2017-03-02 04:53:53]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 04:54:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 06:49:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 06:49:10]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-03-02 18:25:36]

LGTM, increased verbosity does not bother me.

The testing methods seem to have slightly different implementations than the
methods you are switching to.  Do any of these differences mateter?

[sdefresne, 2017-03-02 19:24:48]

On 2017/03/02 18:25:36, rohitrao wrote:
> LGTM, increased verbosity does not bother me.
> 
> The testing methods seem to have slightly different implementations than the
> methods you are switching to.  Do any of these differences mateter?

The testing methods were only used for the tests, so the difference do not
really matter (if there is difference, it just mean that the test code is now
closer to real usage). The main difference is that the testing code is not
sending some notifications and is not starting the network request. First point
is not a problem since there are no observers during testing, the second point
is dealt by setting webUsageEnabled to NO in the TabModel (all test pass with
this value).

[sdefresne, 2017-03-02 19:24:53]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-03-02 19:25:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 19:44:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488482693786970,
"parent_rev": "3ad2c91a82cabaf8d2198c815f96c919d4ed5dc6", "commit_rev":
"8dd0cb3cdf573d6ea0021f2962ef8116c9e80857"}

[commit-bot: I haz the power, 2017-03-02 19:44:44]

Description was changed from

==========
Convert TabModelTest to use the public API of TabModel.

Give a unique window name to all the inserted Tabs and disable web
usage on the TabModel. With those changes it is possible to restrict
TabModelTest to use the public API of TabModel.

Using the public API makes it easier to refactor the code (as there
is no dependency on the implementation or hole into it from the test).

BUG=687207
==========

to

==========
Convert TabModelTest to use the public API of TabModel.

Give a unique window name to all the inserted Tabs and disable web
usage on the TabModel. With those changes it is possible to restrict
TabModelTest to use the public API of TabModel.

Using the public API makes it easier to refactor the code (as there
is no dependency on the implementation or hole into it from the test).

BUG=687207

Review-Url: https://codereview.chromium.org/2715753002
Cr-Commit-Position: refs/heads/master@{#454345}
Committed:
https://chromium.googlesource.com/chromium/src/+/8dd0cb3cdf573d6ea0021f2962ef...
==========

[commit-bot: I haz the power, 2017-03-02 19:44:45]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8dd0cb3cdf573d6ea0021f2962ef...