Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2715753002: Convert TabModelTest to use the public API of TabModel. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.h ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.mm
diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm
index 35ffac1bd11f1b3c91e9e3dca43f08a4e9b9ef47..13a18f8e953bc550ce60c4ca8623a70ca055df4e 100644
--- a/ios/chrome/browser/tabs/tab_model.mm
+++ b/ios/chrome/browser/tabs/tab_model.mm
@@ -973,32 +973,3 @@ Tab* GetOpenerForTab(id<NSFastEnumeration> tabs, Tab* tab) {
}
@end
-
-@implementation TabModel (PrivateForTestingOnly)
-
-- (Tab*)addTabWithURL:(const GURL&)URL referrer:(const web::Referrer&)referrer {
- return [self insertTabWithURL:URL
- referrer:referrer
- opener:nil
- atIndex:self.count];
-}
-
-- (Tab*)insertTabWithURL:(const GURL&)URL
- referrer:(const web::Referrer&)referrer
- opener:(Tab*)parentTab
- atIndex:(NSUInteger)index {
- DCHECK(_browserState);
- base::scoped_nsobject<Tab> tab([[Tab alloc] initWithBrowserState:_browserState
- opener:parentTab
- openedByDOM:NO
- model:self]);
- web::NavigationManager::WebLoadParams params(URL);
- params.referrer = referrer;
- params.transition_type = ui::PAGE_TRANSITION_TYPED;
- [[tab webController] loadWithParams:params];
- [tab webController].webUsageEnabled = webUsageEnabled_;
- [self insertTab:tab atIndex:index opener:parentTab];
- return tab;
-}
-
-@end
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.h ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698