Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2701893002: android: Remove command line from bind (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by boliu
Modified:
4 months, 1 week ago
Reviewers:
Maria
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove command line from bind The command line argument is no longer sent in the intent. This is a tiny clean up following tohttps://codereview.chromium.org/2560403002 BUG=689758 Review-Url: https://codereview.chromium.org/2701893002 Cr-Commit-Position: refs/heads/master@{#451383} Committed: https://chromium.googlesource.com/chromium/src/+/3e7384263148e6719c894b1457ee1cf92c01ef21

Patch Set 1 #

Patch Set 2 : remove comment #

Patch Set 3 : fix junit test compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 5 chunks +6 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (11 generated)
boliu
ptal, tiny clean up
4 months, 1 week ago (2017-02-17 18:53:22 UTC) #4
Maria
lgtm
4 months, 1 week ago (2017-02-17 19:06:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701893002/20001
4 months, 1 week ago (2017-02-17 19:08:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/213505)
4 months, 1 week ago (2017-02-17 19:43:13 UTC) #11
boliu
On 2017/02/17 19:43:13, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 months, 1 week ago (2017-02-17 19:59:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701893002/40001
4 months, 1 week ago (2017-02-17 19:59:55 UTC) #15
commit-bot: I haz the power
4 months, 1 week ago (2017-02-17 21:23:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3e7384263148e6719c894b1457ee...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318