Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2455)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2701893002: android: Remove command line from bind (Closed)
Patch Set: fix junit test compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index 0b2fee2ab8c80e05ef3257205541b85c66dd68f0..ea831b643ffbca824c96f09e489cecfcf78af52c 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -131,7 +131,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
mBindFlags = bindFlags;
}
- boolean bind(String[] commandLine) {
+ boolean bind() {
if (!mBound) {
try {
TraceEvent.begin("ChildProcessConnectionImpl.ChildServiceConnection.bind");
@@ -323,7 +323,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
}
@Override
- public void start(String[] commandLine, ChildProcessConnection.StartCallback startCallback) {
+ public void start(ChildProcessConnection.StartCallback startCallback) {
try {
TraceEvent.begin("ChildProcessConnectionImpl.start");
synchronized (mLock) {
@@ -333,13 +333,13 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
mStartCallback = startCallback;
- if (!mInitialBinding.bind(commandLine)) {
+ if (!mInitialBinding.bind()) {
Log.e(TAG, "Failed to establish the service connection.");
// We have to notify the caller so that they can free-up associated resources.
// TODO(ppi): Can we hard-fail here?
mDeathCallback.onChildProcessDied(ChildProcessConnectionImpl.this);
} else {
- mWaivedBinding.bind(null);
+ mWaivedBinding.bind();
}
}
} finally {
@@ -493,7 +493,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
return;
}
if (mStrongBindingCount == 0) {
- mStrongBinding.bind(null);
+ mStrongBinding.bind();
}
mStrongBindingCount++;
}
@@ -528,7 +528,7 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
Log.w(TAG, "The connection is not bound for %d", mPid);
return;
}
- mModerateBinding.bind(null);
+ mModerateBinding.bind();
}
}

Powered by Google App Engine
This is Rietveld 408576698