Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2696023002
Cr-Commit-Position: refs/heads/master@{#451347}
Committed: https://chromium.googlesource.com/chromium/src/+/6b691a8d8165432b59ae096c1f1ed91b5ee3d306

[zakerinasab, 2017-02-15 16:34:24]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-15 16:34:25]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2017-02-16 15:59:28]

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-shadow.html
(right):

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-shadow.html:74:
t.step(drawImageToCanvasAndCheckPixels);
Are you sure this works correctly?

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-drawImage-shadow.html
(right):

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-drawImage-shadow.html:79:
function drawImageToCanvasAndCheckPixels() {
it is a bit weird that you have to onload handlers that call this, meaning it
will get called twice.  This is likely to be flaky IMHO.  Use HTML image tags
instead of "new Image()" And then you can just rely on window.onload, which
fires once all the document's resources are loaded.  You could do the same thing
for canvas-drawImage-shadow.html to avoid using async_test there.

[zakerinasab, 2017-02-16 20:11:28]

Comments addressed.

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-shadow.html
(right):

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-shadow.html:74:
t.step(drawImageToCanvasAndCheckPixels);
On 2017/02/16 15:59:28, Justin Novosad wrote:
> Are you sure this works correctly?

generate_tests replaced with a loop.

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-drawImage-shadow.html
(right):

https://codereview.chromium.org/2696023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/canvas-scale-drawImage-shadow.html:79:
function drawImageToCanvasAndCheckPixels() {
On 2017/02/16 15:59:28, Justin Novosad wrote:
> it is a bit weird that you have to onload handlers that call this, meaning it
> will get called twice.  This is likely to be flaky IMHO.  Use HTML image tags
> instead of "new Image()" And then you can just rely on window.onload, which
> fires once all the document's resources are loaded.  You could do the same
thing
> for canvas-drawImage-shadow.html to avoid using async_test there.

generate_tests replaced with loops in an async_test.

[Justin Novosad, 2017-02-17 16:21:02]

could you rebase this patch please.

[zakerinasab, 2017-02-17 16:30:24]

On 2017/02/17 16:21:02, Justin Novosad wrote:
> could you rebase this patch please.

Rebaseline done.

[Justin Novosad, 2017-02-17 17:57:14]

lgtm

[zakerinasab, 2017-02-17 18:34:37]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-17 18:35:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:00:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487356477487950,
"parent_rev": "f8d4a274f71dab0cc2e1d332913657b8d04223b5", "commit_rev":
"6b691a8d8165432b59ae096c1f1ed91b5ee3d306"}

[commit-bot: I haz the power, 2017-02-17 19:01:09]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects at most 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2696023002
Cr-Commit-Position: refs/heads/master@{#451347}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b691a8d8165432b59ae096c1f1e...
==========

[commit-bot: I haz the power, 2017-02-17 19:01:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6b691a8d8165432b59ae096c1f1e...