Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver_impl.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index 875da2abaf90267be1320ceaf53b57eeb9b0a548..b269fd158c1a63e49fc9c8c425b9ad00bf3fa7c5 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -123,9 +123,6 @@ class FaviconHandler {
// Returns whether the user is operating in an off-the-record context.
virtual bool IsOffTheRecord() = 0;
- // Returns whether |url| is bookmarked.
- virtual bool IsBookmarked(const GURL& url) = 0;
-
// Notifies that the favicon image has been updated. Most delegates
// propagate the notification to FaviconDriverObserver::OnFaviconUpdated().
// See its documentation for details.
@@ -253,8 +250,6 @@ class FaviconHandler {
const std::vector<SkBitmap>& bitmaps,
const std::vector<gfx::Size>& original_bitmap_sizes);
- bool ShouldSaveFavicon(const GURL& page_url) const;
-
// Updates |best_favicon_| and returns true if it was considered a satisfying
// image (e.g. exact size match).
bool UpdateFaviconCandidate(const DownloadedFavicon& downloaded_favicon);
« no previous file with comments | « components/favicon/core/favicon_driver_impl.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698