Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: components/favicon/core/favicon_driver_impl.cc

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_driver_impl.h ('k') | components/favicon/core/favicon_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.cc
diff --git a/components/favicon/core/favicon_driver_impl.cc b/components/favicon/core/favicon_driver_impl.cc
index 6dd1a7a312637e6cb3b91b2189ec4f52c68bb5e1..d754e4adb35fd3788e44f14707d737b5d6d99658 100644
--- a/components/favicon/core/favicon_driver_impl.cc
+++ b/components/favicon/core/favicon_driver_impl.cc
@@ -9,7 +9,6 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
#include "build/build_config.h"
-#include "components/bookmarks/browser/bookmark_model.h"
#include "components/favicon/core/favicon_driver_observer.h"
#include "components/favicon/core/favicon_handler.h"
#include "components/favicon/core/favicon_service.h"
@@ -48,11 +47,8 @@ void RecordCandidateMetrics(const std::vector<FaviconURL>& candidates) {
} // namespace
FaviconDriverImpl::FaviconDriverImpl(FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model)
- : favicon_service_(favicon_service),
- history_service_(history_service),
- bookmark_model_(bookmark_model) {
+ history::HistoryService* history_service)
+ : favicon_service_(favicon_service), history_service_(history_service) {
if (!favicon_service_)
return;
@@ -76,10 +72,6 @@ void FaviconDriverImpl::FetchFavicon(const GURL& page_url,
handler->FetchFavicon(page_url, is_same_document);
}
-bool FaviconDriverImpl::IsBookmarked(const GURL& url) {
- return bookmark_model_ && bookmark_model_->IsBookmarked(url);
-}
-
bool FaviconDriverImpl::HasPendingTasksForTest() {
for (const std::unique_ptr<FaviconHandler>& handler : handlers_) {
if (handler->HasPendingTasksForTest())
« no previous file with comments | « components/favicon/core/favicon_driver_impl.h ('k') | components/favicon/core/favicon_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698