Fix leaking page visits in incognito mode via bookmarked favicons

components/favicon/core/favicon_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
 
 #include <stddef.h>
 
 #include <set>
@@ skipping 105 matching lines @@
                               int max_image_size,
                               ImageDownloadCallback callback) = 0;
 
     // Downloads a WebManifest and returns the favicons listed there.
     virtual void DownloadManifest(const GURL& url,
                                   ManifestDownloadCallback callback) = 0;
 
     // Returns whether the user is operating in an off-the-record context.
     virtual bool IsOffTheRecord() = 0;
 
-    // Returns whether |url| is bookmarked.
-    virtual bool IsBookmarked(const GURL& url) = 0;
-
     // Notifies that the favicon image has been updated. Most delegates
     // propagate the notification to FaviconDriverObserver::OnFaviconUpdated().
     // See its documentation for details.
     virtual void OnFaviconUpdated(
         const GURL& page_url,
         FaviconDriverObserver::NotificationIconType notification_icon_type,
         const GURL& icon_url,
         bool icon_url_changed,
         const gfx::Image& image) = 0;
   };
@@ skipping 107 matching lines @@
 
   // Triggered when a download of an image has finished.
   void OnDidDownloadFavicon(
       favicon_base::IconType icon_type,
       int id,
       int http_status_code,
       const GURL& image_url,
       const std::vector<SkBitmap>& bitmaps,
       const std::vector<gfx::Size>& original_bitmap_sizes);
 
-  bool ShouldSaveFavicon(const GURL& page_url) const;
-
   // Updates |best_favicon_| and returns true if it was considered a satisfying
   // image (e.g. exact size match).
   bool UpdateFaviconCandidate(const DownloadedFavicon& downloaded_favicon);
 
   // Sets the image data for the favicon.
   void SetFavicon(const GURL& icon_url,
                   const gfx::Image& image,
                   favicon_base::IconType icon_type);
 
   // Notifies |driver_| that FaviconHandler found an icon which matches the
@@ skipping 106 matching lines @@
   // UpdateFaviconCandidate()), the favicon service and the delegate are
   // notified.
   DownloadedFavicon best_favicon_;
 
   DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
 };
 
 }  // namespace favicon
 
 #endif  // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_