Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: net/quic/core/crypto/crypto_utils_test.cc

Issue 2566783002: Various formatting cleanups to net/quic/crypto and net/quic/congestion_control (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/crypto_utils.h ('k') | net/quic/core/crypto/curve25519_key_exchange_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/crypto_utils_test.cc
diff --git a/net/quic/core/crypto/crypto_utils_test.cc b/net/quic/core/crypto/crypto_utils_test.cc
index 340352337991288683669744c7bcb179d7f76c83..1b34c50696073f2c0a0755120e8923860ba489f0 100644
--- a/net/quic/core/crypto/crypto_utils_test.cc
+++ b/net/quic/core/crypto/crypto_utils_test.cc
@@ -4,6 +4,7 @@
#include "net/quic/core/crypto/crypto_utils.h"
+#include "net/quic/core/quic_utils.h"
#include "net/quic/test_tools/quic_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -18,9 +19,8 @@ TEST(CryptoUtilsTest, IsValidSNI) {
EXPECT_FALSE(CryptoUtils::IsValidSNI("192.168.0.1"));
// SNI without any dot.
EXPECT_FALSE(CryptoUtils::IsValidSNI("somedomain"));
- // Invalid RFC2396 hostname
- // TODO(rtenneti): Support RFC2396 hostname.
- // EXPECT_FALSE(CryptoUtils::IsValidSNI("some_domain.com"));
+ // Invalid by RFC2396 but unfortunately domains of this form exist.
+ EXPECT_TRUE(CryptoUtils::IsValidSNI("some_domain.com"));
// An empty string must be invalid otherwise the QUIC client will try sending
// it.
EXPECT_FALSE(CryptoUtils::IsValidSNI(""));
« no previous file with comments | « net/quic/core/crypto/crypto_utils.h ('k') | net/quic/core/crypto/curve25519_key_exchange_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698