Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253543002: web_dev_style: check webui browser tests as well. (Closed)

Created:
6 years, 8 months ago by Dan Beam
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, Ilya Sherman, yusukes+watch_chromium.org, dyu1, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, tfarina, yoshiki+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, benquan, rginda+watch_chromium.org, dbeam+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, rouslan+autofillwatch_chromium.org, Dane Wallinga
Visibility:
Public.

Description

web_dev_style: check webui browser tests as well. Moves: c/b/resources/PRESUBMIT.py => c/b/PRESUBMIT.py c/b/resources/web_dev_style/ => c/b/web_dev_style/ so c/b/ui/webui/*browsertest.js files can be presubmit checked as well. R=tbreisacher@chromium.org BUG=366960 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267594

Patch Set 1 : less scary #

Patch Set 2 : merge #

Total comments: 4

Patch Set 3 : tbreisacher@ review #

Total comments: 2

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -1553 lines) Patch
M chrome/browser/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/PRESUBMIT.py View 1 2 3 3 chunks +17 lines, -11 lines 0 comments Download
D chrome/browser/resources/PRESUBMIT.py View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/resources/test_presubmit.py View 1 2 3 1 chunk +0 lines, -666 lines 0 comments Download
D chrome/browser/resources/web_dev_style/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/web_dev_style/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/web_dev_style/css_checker.py View 1 chunk +0 lines, -372 lines 0 comments Download
D chrome/browser/resources/web_dev_style/js_checker.py View 1 2 3 1 chunk +0 lines, -255 lines 0 comments Download
A + chrome/browser/test_presubmit.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_ui_browsertest.js View 1 2 1 chunk +23 lines, -22 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/identity_internals_ui_browsertest.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_browsertest.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_browsertest.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/options_browsertest.js View 9 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/options/settings_format_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/startup_page_list_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_browsertest.js View 3 chunks +124 lines, -124 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_browsertest.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/web_dev_style/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/web_dev_style/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/web_dev_style/css_checker.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/web_dev_style/js_checker.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Dan Beam
6 years, 8 months ago (2014-04-25 01:36:48 UTC) #1
Tyler Breisacher (Chromium)
lgtm https://codereview.chromium.org/253543002/diff/60001/chrome/browser/ui/webui/downloads_ui_browsertest.js File chrome/browser/ui/webui/downloads_ui_browsertest.js (right): https://codereview.chromium.org/253543002/diff/60001/chrome/browser/ui/webui/downloads_ui_browsertest.js#newcode82 chrome/browser/ui/webui/downloads_ui_browsertest.js:82: download.received = 128; Out of curiosity, do you ...
6 years, 7 months ago (2014-04-28 23:13:26 UTC) #2
Dan Beam
+thestig@ for chrome/browser/ file move (see description) https://codereview.chromium.org/253543002/diff/60001/chrome/browser/ui/webui/downloads_ui_browsertest.js File chrome/browser/ui/webui/downloads_ui_browsertest.js (right): https://codereview.chromium.org/253543002/diff/60001/chrome/browser/ui/webui/downloads_ui_browsertest.js#newcode82 chrome/browser/ui/webui/downloads_ui_browsertest.js:82: download.received = ...
6 years, 7 months ago (2014-04-28 23:54:06 UTC) #3
Lei Zhang
https://codereview.chromium.org/253543002/diff/80001/chrome/browser/PRESUBMIT.py File chrome/browser/PRESUBMIT.py (right): https://codereview.chromium.org/253543002/diff/80001/chrome/browser/PRESUBMIT.py#newcode5 chrome/browser/PRESUBMIT.py:5: """Presubmit script for Chromium WebUI resources. It's a bit ...
6 years, 7 months ago (2014-04-29 03:05:47 UTC) #4
Lei Zhang
Otherwise lgtm
6 years, 7 months ago (2014-04-29 03:06:54 UTC) #5
Dan Beam
https://codereview.chromium.org/253543002/diff/80001/chrome/browser/PRESUBMIT.py File chrome/browser/PRESUBMIT.py (right): https://codereview.chromium.org/253543002/diff/80001/chrome/browser/PRESUBMIT.py#newcode5 chrome/browser/PRESUBMIT.py:5: """Presubmit script for Chromium WebUI resources. On 2014/04/29 03:05:48, ...
6 years, 7 months ago (2014-04-29 16:32:21 UTC) #6
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 7 months ago (2014-04-29 16:44:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/253543002/120001
6 years, 7 months ago (2014-04-29 16:45:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:12:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:12:08 UTC) #10
Dan Beam
Committed patchset #4 manually as r266336 (presubmit passed [locally at least]). This is actually dbeam@, ...
6 years, 7 months ago (2014-05-01 18:48:08 UTC) #11
Dan Beam
6 years, 7 months ago (2014-05-01 20:14:07 UTC) #12
Message was sent while issue was closed. 
On 2014/05/01 18:48:08, Dan Beam wrote:
> Committed patchset #4 manually as r266336 (presubmit passed [locally at
least]).
>  This is actually dbeam@, not a robot.

er, I mean r267594

Powered by Google App Engine
This is Rietveld 408576698