Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 253543002: web_dev_style: check webui browser tests as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/test_presubmit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
deleted file mode 100644
index 831864c33b4236beca0807becff5abbbd535997f..0000000000000000000000000000000000000000
--- a/chrome/browser/resources/PRESUBMIT.py
+++ /dev/null
@@ -1,63 +0,0 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Presubmit script for Chromium WebUI resources.
-
-See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
-for more details about the presubmit API built into gcl/git cl, and see
-http://www.chromium.org/developers/web-development-style-guide for the rules
-we're checking against here.
-"""
-
-
-def CheckChangeOnUpload(input_api, output_api):
- return _CommonChecks(input_api, output_api)
-
-
-def CheckChangeOnCommit(input_api, output_api):
- return _CommonChecks(input_api, output_api)
-
-
-def _CommonChecks(input_api, output_api):
- """Checks common to both upload and commit."""
- results = []
- resources = input_api.PresubmitLocalPath()
-
- path = input_api.os_path
- affected_files = (f.AbsoluteLocalPath() for f in input_api.AffectedFiles())
- would_affect_tests = (
- path.join(resources, 'PRESUBMIT.py'),
- path.join(resources, 'test_presubmit.py'),
- path.join(resources, 'web_dev_style', 'css_checker.py'),
- path.join(resources, 'web_dev_style', 'js_checker.py'),
- )
- if any(f for f in affected_files if f in would_affect_tests):
- tests = [path.join(resources, 'test_presubmit.py')]
- results.extend(
- input_api.canned_checks.RunUnitTests(input_api, output_api, tests))
-
- import sys
- old_path = sys.path
-
- try:
- sys.path = [resources] + old_path
- from web_dev_style import css_checker, js_checker
-
- def _html_css_js_resource(p):
- return p.endswith(('.html', '.css', '.js')) and p.startswith(resources)
-
- BLACKLIST = ['chrome/browser/resources/pdf/index.html',
- 'chrome/browser/resources/pdf/index.js']
- def is_resource(maybe_resource):
- return (maybe_resource.LocalPath() not in BLACKLIST and
- _html_css_js_resource(maybe_resource.AbsoluteLocalPath()))
-
- results.extend(css_checker.CSSChecker(
- input_api, output_api, file_filter=is_resource).RunChecks())
- results.extend(js_checker.JSChecker(
- input_api, output_api, file_filter=is_resource).RunChecks())
- finally:
- sys.path = old_path
-
- return results
« no previous file with comments | « chrome/browser/PRESUBMIT.py ('k') | chrome/browser/resources/test_presubmit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698