chrome/browser/web_dev_style/css_checker.py - Issue 253543002: web_dev_style: check webui browser tests as well.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/web_dev_style/css_checker.py

Issue 253543002: web_dev_style: check webui browser tests as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/web_dev_style/__init__.py ('k') | chrome/browser/web_dev_style/js_checker.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for Chromium WebUI resources.	5 """Presubmit script for Chromium WebUI resources.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into gcl/git cl, and see	8 for more details about the presubmit API built into gcl/git cl, and see

9 http://www.chromium.org/developers/web-development-style-guide for the rules	9 http://www.chromium.org/developers/web-development-style-guide for the rules

10 we're checking against here.	10 we're checking against here.

(...skipping 352 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
363 '%s:\n%s' % (f[0], '\n\n'.join(file_errors))))	363 '%s:\n%s' % (f[0], '\n\n'.join(file_errors))))

364	364

365 if results:	365 if results:

366 # Add your name if you're here often mucking around in the code.	366 # Add your name if you're here often mucking around in the code.

367 authors = ['dbeam@chromium.org']	367 authors = ['dbeam@chromium.org']

368 results.append(self.output_api.PresubmitNotifyResult(	368 results.append(self.output_api.PresubmitNotifyResult(

369 'Was the CSS checker useful? Send feedback or hate mail to %s.' %	369 'Was the CSS checker useful? Send feedback or hate mail to %s.' %

370 ', '.join(authors)))	370 ', '.join(authors)))

371	371

372 return results	372 return results

OLD	NEW