Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 25195003: Prepare to move core/platform/text into blink_platform.dll (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
jamesr, eseidel
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, dino_apple.com, do-not-use, Nils Barth (inactive), jamesr, Nate Chapin, alancutter (OOO until 2018), dstockwell, dsinclair, Timothy Loh, abarth-chromium, danakj, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, pdr., Eric Willigers, nessy, rjwright, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, haraken, kojih, vcarbune.chromium, jsbell+bindings_chromium.org, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), Steve Block, f(malita), groby+blinkspell_chromium.org, Stephen Chennney, jeez
Visibility:
Public.

Description

Prepare to move core/platform/text into blink_platform.dll This CL moves NotImplemented, Logging, Language, and DateComponents into blink_platform.dll because core/platform/text depends on this code. After this CL lands, we'll be ready to move the bulk of core/platform/text into blink_platform.dll. In order to move this code into the DLL, I had to change how blink_common.dll works a bit. Instead of being defined in web.gyp, I've moved the definition to blink_platform.gyp to avoid a circular GYP dependency (because web.gyp depends on blink_platform.gyp). This change makes sense because blink_common.dll is really a tiny sliver of blink_platform.dll that's needed in the browser process on Windows. To maintain sanity, I've also moved the source files for blink_common.dll into Source/platform. BUG=297477 R=jamesr Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158518

Patch Set 1 #

Patch Set 2 : re-attempt upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -1925 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseDateAndTimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/DateInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/MonthInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/WeekInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeFieldElements.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/HistoryController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/DateComponents.h View 1 chunk +0 lines, -213 lines 0 comments Download
D Source/core/platform/DateComponents.cpp View 1 chunk +0 lines, -723 lines 0 comments Download
D Source/core/platform/Language.h View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/core/platform/Language.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
M Source/core/platform/LocalizedStrings.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/Logging.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/platform/Logging.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D Source/core/platform/NotImplemented.h View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/core/platform/NotImplemented.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M Source/core/platform/audio/FFTFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/FileSystemChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/PlatformKeyboardEventChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/SoundChromiumPosix.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/chromium/support/WebCString.cpp View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/core/platform/chromium/support/WebString.cpp View 1 chunk +0 lines, -160 lines 0 comments Download
Source/core/platform/cocoa/KeyEventCocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/ContentDecryptionModule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/ContentDecryptionModuleSession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/Extensions3D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/chromium/FontChromiumWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/custom/CustomFilterValidatedProgram.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/harfbuzz/FontHarfBuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/win/FontCustomPlatformDataWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/network/SocketStreamHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/sql/SQLiteDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/sql/SQLiteStatement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/LocaleICU.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/PlatformLocale.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/platform/text/TextBreakIteratorInternalICU.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/mac/LocaleMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/win/LocaleWin.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/tests/PODIntervalTreeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/MediaStreamAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseSync.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/SQLTransactionStateMachine.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketDeflater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/DateComponents.h View 2 chunks +2 lines, -1 line 0 comments Download
A + Source/platform/DateComponents.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/Language.h View 1 chunk +6 lines, -5 lines 0 comments Download
Source/platform/Language.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/Logging.h View 2 chunks +29 lines, -27 lines 0 comments Download
A + Source/platform/Logging.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/NotImplemented.h View 2 chunks +2 lines, -1 line 0 comments Download
A + Source/platform/NotImplemented.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gyp View 1 chunk +26 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
A + Source/platform/exported/WebCString.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/exported/WebCommon.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/exported/WebString.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/InspectorFrontendClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/web/WebCommon.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
Source/web/WebKit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LocaleMacTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/LocaleWinTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/web.gyp View 3 chunks +1 line, -28 lines 0 comments Download
M public/blink.gyp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-09-30 04:52:17 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-09-30 05:04:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/25195003/4001
7 years, 2 months ago (2013-09-30 05:45:04 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 07:16:48 UTC) #4
Message was sent while issue was closed.
Change committed as 158518

Powered by Google App Engine
This is Rietveld 408576698