Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 251623003: webui: rename "DialogClose" to "dialogClose" to match other webui messages. (Closed)

Created:
6 years, 8 months ago by Dan Beam
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

webui: rename "DialogClose" to "dialogClose" to match other webui messages. R=thakis@chromium.org BUG=none TEST=no DCHECK()s about unhandled webui messages fire Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/resources/chromeos/bluetooth_pair_device.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/charger_replacement.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/inline_login/inline_login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/web_dialogs/web_dialog_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Dan Beam
fyi: there's a DCHECK() that fires for unhandled chrome.send() messages here: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/webui/web_ui_impl.cc&l=216
6 years, 8 months ago (2014-04-24 23:56:52 UTC) #1
Nico
rslgtm Here's hoping all these have test coverge!
6 years, 8 months ago (2014-04-25 00:00:16 UTC) #2
Nico
coverage!
6 years, 8 months ago (2014-04-25 00:00:22 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-25 00:06:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/251623003/1
6 years, 8 months ago (2014-04-25 00:09:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 02:48:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 02:48:52 UTC) #7
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-25 02:52:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/251623003/1
6 years, 8 months ago (2014-04-25 02:55:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 03:06:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-25 03:06:48 UTC) #11
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 8 months ago (2014-04-25 04:06:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/251623003/1
6 years, 8 months ago (2014-04-25 08:23:46 UTC) #13
Dan Beam
6 years, 8 months ago (2014-04-25 21:28:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 manually as r266246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698