Build chromium_gpu_debug_builder target on debug bots.

Build chromium_gpu_debug_builder target on debug bots.

BUG=286398
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=225609

[Ken Russell (switch to Gerrit), 2013-09-26 23:03:46]

Please review. Thanks.

(This issue came up while switching over the try servers to the new recipe.)

[iannucci, 2013-09-26 23:22:30]

https://codereview.chromium.org/24878003/diff/1/scripts/slave/recipes/gpu.py
File scripts/slave/recipes/gpu.py (right):

https://codereview.chromium.org/24878003/diff/1/scripts/slave/recipes/gpu.py#...
scripts/slave/recipes/gpu.py:63: yield
api.chromium.compile(targets=['chromium_gpu_debug_builder'])
What about:

tag = '' if is_release_build else 'debug_'
yield api.chromium.compile(targets=['chromium_gpu_%sbuilder' % tag])

[Ken Russell (switch to Gerrit), 2013-09-26 23:52:41]

https://codereview.chromium.org/24878003/diff/1/scripts/slave/recipes/gpu.py
File scripts/slave/recipes/gpu.py (right):

https://codereview.chromium.org/24878003/diff/1/scripts/slave/recipes/gpu.py#...
scripts/slave/recipes/gpu.py:63: yield
api.chromium.compile(targets=['chromium_gpu_debug_builder'])
On 2013/09/26 23:22:30, iannucci wrote:
> What about:
> 
> tag = '' if is_release_build else 'debug_'
> yield api.chromium.compile(targets=['chromium_gpu_%sbuilder' % tag])

Thanks, that is simpler. Done.

[iannucci, 2013-09-26 23:53:46]

lgtm, though it's very unfortunate that this is an alternate target in gyp...
that smells a lot like a bug to me.

[commit-bot: I haz the power, 2013-09-26 23:58:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/24878003/6001

[commit-bot: I haz the power, 2013-09-26 23:58:50]

Change committed as 225609

[Ken Russell (switch to Gerrit), 2013-09-26 23:59:13]

On 2013/09/26 23:53:46, iannucci wrote:
> lgtm, though it's very unfortunate that this is an alternate target in gyp...
> that smells a lot like a bug to me.

Committing this for now, but would definitely appreciate suggestions on how to
restructure this. I agree that it would be much better to just name the build
targets directly in the recipe.

[iannucci, 2013-09-27 00:04:29]

On 2013/09/26 23:59:13, Ken Russell wrote:
> On 2013/09/26 23:53:46, iannucci wrote:
> > lgtm, though it's very unfortunate that this is an alternate target in
gyp...
> > that smells a lot like a bug to me.
> 
> Committing this for now, but would definitely appreciate suggestions on how to
> restructure this. I agree that it would be much better to just name the build
> targets directly in the recipe.

Well... right now you could build chromium_gpu_builder in 'Debug' mode, and
chromium_gpu_debug_builder in 'Release' mode. Madness, I tell you! :)

Wouldn't it be possible to just have chromium_gpu_builder which inspects the
target gyp variable to determine what to do?