Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: scripts/slave/recipes/gpu.py

Issue 24878003: Build chromium_gpu_debug_builder target on debug bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Applied simplification suggested by iannucci@. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu.expected/linux_debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/gpu.py
diff --git a/scripts/slave/recipes/gpu.py b/scripts/slave/recipes/gpu.py
index 1e7ddac87ac62f3bce305785b725da17225dbcfd..2b399fdcb7ba78d1ed183f357a17aec3efe9d96c 100644
--- a/scripts/slave/recipes/gpu.py
+++ b/scripts/slave/recipes/gpu.py
@@ -31,6 +31,8 @@ def GenSteps(api):
reference_dir = api.path.slave_build('content_gpu_data', 'reference')
gsutil = api.path.build('scripts', 'slave', 'gsutil', wrapper=True)
+ is_release_build = api.properties.get('build_config', 'Release') == 'Release'
+
api.chromium.set_config('chromium')
api.gclient.apply_config('chrome_internal')
@@ -53,7 +55,10 @@ def GenSteps(api):
if 'rietveld' in api.properties:
yield api.rietveld.apply_issue()
yield api.chromium.runhooks()
- yield api.chromium.compile(targets=['chromium_gpu_builder'])
+ # Since performance tests aren't run on the debug builders, it isn't
+ # necessary to build all of the targets there.
+ build_tag = '' if is_release_build else 'debug_'
+ yield api.chromium.compile(targets=['chromium_gpu_%sbuilder' % build_tag])
# TODO(kbr): currently some properties are passed to runtest.py via
# factory_properties in the master.cfg: generate_gtest_json,
@@ -96,7 +101,7 @@ def GenSteps(api):
args, always_run=True)
# Only run the performance tests on Release builds.
- if api.properties.get('build_config', 'Release') == 'Release':
+ if is_release_build:
# Former gpu_frame_rate_test step
args = ['--enable-gpu',
'--gtest_filter=FrameRate*Test*']
« no previous file with comments | « no previous file | scripts/slave/recipes/gpu.expected/linux_debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698