Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: Source/core/dom/shadow/InsertionPoint.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/shadow/ElementShadow.cpp ('k') | Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/shadow/InsertionPoint.cpp
diff --git a/Source/core/dom/shadow/InsertionPoint.cpp b/Source/core/dom/shadow/InsertionPoint.cpp
index 7d05daaf2b336d464a6778eca6fd33cef156edba..d183c743314740c86d8b3112c9be8726267bb704 100644
--- a/Source/core/dom/shadow/InsertionPoint.cpp
+++ b/Source/core/dom/shadow/InsertionPoint.cpp
@@ -100,7 +100,7 @@ void InsertionPoint::attach(const AttachContext& context)
// FIXME: This loop shouldn't be needed since the distributed nodes should
// never be detached, we can probably remove it.
for (size_t i = 0; i < m_distribution.size(); ++i) {
- if (!m_distribution.at(i)->attached())
+ if (!m_distribution.at(i)->confusingAndOftenMisusedAttached())
m_distribution.at(i)->attach(context);
}
@@ -222,7 +222,7 @@ void InsertionPoint::removedFrom(ContainerNode* insertionPoint)
void InsertionPoint::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
if (name == reset_style_inheritanceAttr) {
- if (!inDocument() || !attached() || !isActive())
+ if (!inDocument() || !confusingAndOftenMisusedAttached() || !isActive())
return;
containingShadowRoot()->host()->setNeedsStyleRecalc();
} else
« no previous file with comments | « Source/core/dom/shadow/ElementShadow.cpp ('k') | Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698