Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: Source/core/dom/FullscreenElementStack.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/ElementRareData.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.cpp
diff --git a/Source/core/dom/FullscreenElementStack.cpp b/Source/core/dom/FullscreenElementStack.cpp
index e31aab51c7e40db2b32dc514378e2c47111fa34b..bf797382953a118022c0a56d5d176c5d940f5fe9 100644
--- a/Source/core/dom/FullscreenElementStack.cpp
+++ b/Source/core/dom/FullscreenElementStack.cpp
@@ -351,7 +351,7 @@ bool FullscreenElementStack::webkitFullscreenEnabled(Document* document)
void FullscreenElementStack::webkitWillEnterFullScreenForElement(Element* element)
{
- if (!document()->attached())
+ if (!document()->confusingAndOftenMisusedAttached())
return;
ASSERT(element);
@@ -391,7 +391,7 @@ void FullscreenElementStack::webkitDidEnterFullScreenForElement(Element*)
if (!m_fullScreenElement)
return;
- if (!document()->attached())
+ if (!document()->confusingAndOftenMisusedAttached())
return;
m_fullScreenElement->didBecomeFullscreenElement();
@@ -404,7 +404,7 @@ void FullscreenElementStack::webkitWillExitFullScreenForElement(Element*)
if (!m_fullScreenElement)
return;
- if (!document()->attached())
+ if (!document()->confusingAndOftenMisusedAttached())
return;
m_fullScreenElement->willStopBeingFullscreenElement();
@@ -415,7 +415,7 @@ void FullscreenElementStack::webkitDidExitFullScreenForElement(Element*)
if (!m_fullScreenElement)
return;
- if (!document()->attached())
+ if (!document()->confusingAndOftenMisusedAttached())
return;
m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(false);
« no previous file with comments | « Source/core/dom/ElementRareData.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698