Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: Source/core/accessibility/AccessibilityMenuListPopup.cpp

Issue 24773003: Rename Node::attached() to confusingAndOftenMisusedAttached() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/accessibility/AccessibilityMenuListPopup.cpp
diff --git a/Source/core/accessibility/AccessibilityMenuListPopup.cpp b/Source/core/accessibility/AccessibilityMenuListPopup.cpp
index 53fe8fdbcc1c63a5699f6ade9be0a3aa971f0f05..66722fc889b7cd3174556102bd172d57db5414f1 100644
--- a/Source/core/accessibility/AccessibilityMenuListPopup.cpp
+++ b/Source/core/accessibility/AccessibilityMenuListPopup.cpp
@@ -66,7 +66,7 @@ bool AccessibilityMenuListPopup::computeAccessibilityIsIgnored() const
AccessibilityMenuListOption* AccessibilityMenuListPopup::menuListOptionAccessibilityObject(HTMLElement* element) const
{
- if (!element || !element->hasTagName(optionTag) || !element->attached())
+ if (!element || !element->hasTagName(optionTag) || !element->confusingAndOftenMisusedAttached())
return 0;
AccessibilityObject* object = document()->axObjectCache()->getOrCreate(MenuListOptionRole);
@@ -114,7 +114,7 @@ void AccessibilityMenuListPopup::childrenChanged()
AXObjectCache* cache = axObjectCache();
for (size_t i = m_children.size(); i > 0 ; --i) {
AccessibilityObject* child = m_children[i - 1].get();
- if (child->actionElement() && !child->actionElement()->attached()) {
+ if (child->actionElement() && !child->actionElement()->confusingAndOftenMisusedAttached()) {
child->detachFromParent();
cache->remove(child->axObjectID());
}
« no previous file with comments | « no previous file | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698