Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2446163004: Revert of DevTools: properly restore selected DOMNode in Elements panel. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: properly restore selected DOMNode in Elements panel. (patchset #7 id:120001 of https://chromiumcodereview.appspot.com/2428823002/ ) Reason for revert: Reverting this patch since it doesn't eliminate issue. Original issue's description: > DevTools: properly restore selected DOMNode in Elements panel. > > Since the http://crrev.com/b4d6bf98e, we started > sending two "documentUpdated" events for every > page reload. > > It's not a bad thing by itself (but probably needs > addressing in a follow-up), but the element restoration > logic is unprepared for this. > > This patch re-writes the element restoring logic in the > elements panel. > > BUG=645645 > > Committed: https://crrev.com/247328a16045ca03a0684b76cf1f7de988550453 > Cr-Commit-Position: refs/heads/master@{#426732} TBR=pfeldman@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645645 Committed: https://crrev.com/882009f9a7c57c3351930bd768fb9bbe859d4d31 Cr-Commit-Position: refs/heads/master@{#427640}

Patch Set 1 #

Messages

Total messages: 10 (4 generated)
lushnikov
Created Revert of DevTools: properly restore selected DOMNode in Elements panel.
4 years, 1 month ago (2016-10-25 23:27:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446163004/1
4 years, 1 month ago (2016-10-25 23:28:12 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/318983)
4 years, 1 month ago (2016-10-26 02:48:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2446163004/1
4 years, 1 month ago (2016-10-26 07:33:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 08:49:53 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 08:51:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/882009f9a7c57c3351930bd768fb9bbe859d4d31
Cr-Commit-Position: refs/heads/master@{#427640}

Powered by Google App Engine
This is Rietveld 408576698