Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2449963004: Reland of DevTools: properly restore selected DOMNode in Elements panel. (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: properly restore selected DOMNode in Elements panel. This patch is a reland of https://crrev.com/2428823002/, merged with https://crrev.com/2448963003. Since the http://crrev.com/b4d6bf98e, we started sending two "documentUpdated" events for every page reload. It's not a bad thing by itself (but probably needs addressing in a follow-up), but the element restoration logic is unprepared for this. This patch re-writes the element restoring logic in the elements panel so that we will try to restore to the last focused selected element. BUG=645645 R=dgozman Committed: https://crrev.com/f19c680112d1d6fc029b1463ceeb35b7a54297a4 Cr-Commit-Position: refs/heads/master@{#427715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspect-element.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/elements-panel-restore-selection-when-node-comes-later.html View 1 chunk +112 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/elements-panel-restore-selection-when-node-comes-later-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/reveal-whitespace-text-node.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/inspect-deep-shadow-element.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/reveal-shadow-dom-node.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 4 chunks +44 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 2 chunks +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-10-25 23:47:41 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-25 23:48:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2449963004/1
4 years, 1 month ago (2016-10-26 16:45:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 16:50:10 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:12:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f19c680112d1d6fc029b1463ceeb35b7a54297a4
Cr-Commit-Position: refs/heads/master@{#427715}

Powered by Google App Engine
This is Rietveld 408576698