Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html

Issue 2446163004: Revert of DevTools: properly restore selected DOMNode in Elements panel. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html
diff --git a/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html b/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html
index 6dfcb8d76fd4779d1427790c332080320c9d9f4d..d612d373401ab441160bf065ae04f0938cf5d7c6 100644
--- a/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html
+++ b/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-rewrite-href.html
@@ -15,7 +15,6 @@
{
var innerMapping = InspectorTest.domModel._idToDOMNode;
- var outputLines = [];
for (var nodeId in innerMapping) {
var node = innerMapping[nodeId];
if (node.nodeName() === "LINK" || node.nodeName() === "SCRIPT") {
@@ -26,7 +25,7 @@
continue;
}
if (href.startsWith("http:")) {
- outputLines.push(href);
+ InspectorTest.addResult(href);
continue;
}
var parsedURL = href.asParsedURL();
@@ -37,13 +36,11 @@
var split = parsedURL.path.split("/");
for (var i = split.length - 1, j = 0; j < 3 && i >= 0; --i, ++j)
segments.push(split[i]);
- outputLines.push(segments.reverse());
+ InspectorTest.addResult(segments.reverse());
}
if (node.nodeName() === "A")
- outputLines.push(node.resolveURL(node.getAttribute("href")));
+ InspectorTest.addResult(node.resolveURL(node.getAttribute("href")));
}
- outputLines.sort();
- InspectorTest.addResult(outputLines.join("\n"));
InspectorTest.completeTest();
}
}

Powered by Google App Engine
This is Rietveld 408576698