Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2445003002: Reland: Make ChromeVox Next the default ChromeVox experience (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make ChromeVox Next the default ChromeVox experience - removes obsolete key configuration code from options; this leaves options as a simple, clean list of documentable settings - change the tutorial url to point to the Next tutorial Pending/Optional - change the update notification to point to a release note (rather than the tutorial) TBR=dtseng@chromium.org BUG=618097 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d5bbc0a84e55a4e4fe98394cfd265eb7e51ff63a Cr-Commit-Position: refs/heads/master@{#427243}

Patch Set 1 #

Patch Set 2 : speculative fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -389 lines) Patch
M chrome/browser/chromeos/accessibility/speech_monitor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 9 chunks +44 lines, -145 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js View 5 chunks +0 lines, -208 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445003002/60001
4 years, 1 month ago (2016-10-24 21:43:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/285515)
4 years, 1 month ago (2016-10-24 22:42:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445003002/100001
4 years, 1 month ago (2016-10-25 02:16:26 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 1 month ago (2016-10-25 02:21:07 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 02:22:53 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5bbc0a84e55a4e4fe98394cfd265eb7e51ff63a
Cr-Commit-Position: refs/heads/master@{#427243}

Powered by Google App Engine
This is Rietveld 408576698