chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2445003002: Reland: Make ChromeVox Next the default ChromeVox experience

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2445003002: Reland: Make ChromeVox Next the default ChromeVox experience (Closed)

Patch Set: speculative fixes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index b2dbd612750de40d84b80df6fe3d2bbdb3289214..86174b675228552c723c24c8d0cc400d3a5e0f0b 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -994,6 +994,8 @@ Output.prototype = {

return;

var uniqueAncestors = AutomationUtil.getUniqueAncestors(prevParent, parent);

for (var i = 0; parent = uniqueAncestors[i]; i++) {

+ if (parent.role == RoleType.window)

+ break;

if (Output.ROLE_INFO_[parent.role] &&

Output.ROLE_INFO_[parent.role].outputContextFirst) {

this.outputContextFirst_ = true;