Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2442123002: [LayoutNG] Remove one NGConstraintSpace constructor, mark others for removal. (Closed)
Patch Set: remove silly comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
index 92aa92c639408922b7e93c3307bddcb14994aaac..0f647bbb3eab231959b6fa7577c2aadd8ac16670 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc
@@ -13,15 +13,6 @@ namespace blink {
NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
NGDirection direction,
- NGLogicalSize container_size)
- : physical_space_(new NGPhysicalConstraintSpace(
- container_size.ConvertToPhysical(writing_mode))),
- size_(container_size),
- writing_mode_(writing_mode),
- direction_(direction) {}
-
-NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
- NGDirection direction,
NGPhysicalConstraintSpace* physical_space)
: physical_space_(physical_space),
size_(physical_space->ContainerSize().ConvertToLogical(writing_mode)),
@@ -30,10 +21,10 @@ NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
NGDirection direction,
- const NGConstraintSpace* constraint_space)
- : physical_space_(constraint_space->MutablePhysicalSpace()),
- offset_(constraint_space->Offset()),
- size_(constraint_space->Size()),
+ NGLogicalSize container_size)
+ : physical_space_(new NGPhysicalConstraintSpace(
+ container_size.ConvertToPhysical(writing_mode))),
+ size_(container_size),
writing_mode_(writing_mode),
direction_(direction) {}

Powered by Google App Engine
This is Rietveld 408576698