Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

Issue 2442123002: [LayoutNG] Remove one NGConstraintSpace constructor, mark others for removal. (Closed)
Patch Set: remove silly comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_constraint_space.h" 5 #include "core/layout/ng/ng_constraint_space.h"
6 6
7 #include "core/layout/LayoutBlock.h" 7 #include "core/layout/LayoutBlock.h"
8 #include "core/layout/LayoutView.h" 8 #include "core/layout/LayoutView.h"
9 #include "core/layout/ng/ng_layout_opportunity_iterator.h" 9 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
10 #include "core/layout/ng/ng_units.h" 10 #include "core/layout/ng/ng_units.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 14 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
15 NGDirection direction, 15 NGDirection direction,
16 NGLogicalSize container_size)
17 : physical_space_(new NGPhysicalConstraintSpace(
18 container_size.ConvertToPhysical(writing_mode))),
19 size_(container_size),
20 writing_mode_(writing_mode),
21 direction_(direction) {}
22
23 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
24 NGDirection direction,
25 NGPhysicalConstraintSpace* physical_space) 16 NGPhysicalConstraintSpace* physical_space)
26 : physical_space_(physical_space), 17 : physical_space_(physical_space),
27 size_(physical_space->ContainerSize().ConvertToLogical(writing_mode)), 18 size_(physical_space->ContainerSize().ConvertToLogical(writing_mode)),
28 writing_mode_(writing_mode), 19 writing_mode_(writing_mode),
29 direction_(direction) {} 20 direction_(direction) {}
30 21
31 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode, 22 NGConstraintSpace::NGConstraintSpace(NGWritingMode writing_mode,
32 NGDirection direction, 23 NGDirection direction,
33 const NGConstraintSpace* constraint_space) 24 NGLogicalSize container_size)
34 : physical_space_(constraint_space->MutablePhysicalSpace()), 25 : physical_space_(new NGPhysicalConstraintSpace(
35 offset_(constraint_space->Offset()), 26 container_size.ConvertToPhysical(writing_mode))),
36 size_(constraint_space->Size()), 27 size_(container_size),
37 writing_mode_(writing_mode), 28 writing_mode_(writing_mode),
38 direction_(direction) {} 29 direction_(direction) {}
39 30
40 NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other, 31 NGConstraintSpace::NGConstraintSpace(const NGConstraintSpace& other,
41 NGLogicalOffset offset, 32 NGLogicalOffset offset,
42 NGLogicalSize size) 33 NGLogicalSize size)
43 : physical_space_(other.MutablePhysicalSpace()), 34 : physical_space_(other.MutablePhysicalSpace()),
44 offset_(offset), 35 offset_(offset),
45 size_(size), 36 size_(size),
46 writing_mode_(other.WritingMode()), 37 writing_mode_(other.WritingMode()),
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 187
197 String NGConstraintSpace::ToString() const { 188 String NGConstraintSpace::ToString() const {
198 return String::format("%s,%s %sx%s", 189 return String::format("%s,%s %sx%s",
199 offset_.inline_offset.toString().ascii().data(), 190 offset_.inline_offset.toString().ascii().data(),
200 offset_.block_offset.toString().ascii().data(), 191 offset_.block_offset.toString().ascii().data(),
201 size_.inline_size.toString().ascii().data(), 192 size_.inline_size.toString().ascii().data(),
202 size_.block_size.toString().ascii().data()); 193 size_.block_size.toString().ascii().data());
203 } 194 }
204 195
205 } // namespace blink 196 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698