Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2442123002: [LayoutNG] Remove one NGConstraintSpace constructor, mark others for removal. (Closed)
Patch Set: remove silly comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index 7b7904be52113a2524388543339cc93bbe1bcaef..19778664ef90c68493077e4e7d692b00d02302ae 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -25,25 +25,22 @@ class NGLayoutOpportunityIterator;
class CORE_EXPORT NGConstraintSpace final
: public GarbageCollected<NGConstraintSpace> {
public:
- // Constructs a constraint space with a new backing NGPhysicalConstraintSpace.
- // The size will be used for both for the physical constraint space's
- // container size and this constraint space's Size().
- NGConstraintSpace(NGWritingMode, NGDirection, NGLogicalSize);
-
// Constructs a constraint space based on an existing backing
// NGPhysicalConstraintSpace. Sets this constraint space's size to the
// physical constraint space's container size, converted to logical
// coordinates.
- // TODO(layout-ng): Do we need this constructor?
NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*);
- // Constructs a constraint space with a different NGWritingMode and
- // NGDirection that's otherwise identical.
- NGConstraintSpace(NGWritingMode, NGDirection, const NGConstraintSpace*);
+ // Constructs a constraint space with a new backing NGPhysicalConstraintSpace.
+ // The size will be used for both for the physical constraint space's
+ // container size and this constraint space's Size().
+ // TODO(layout-dev): Remove once NGConstraintSpaceBuilder exists.
+ NGConstraintSpace(NGWritingMode, NGDirection, NGLogicalSize);
// Constructs a derived constraint space sharing the same backing
// NGPhysicalConstraintSpace, NGWritingMode and NGDirection. Primarily for use
// by NGLayoutOpportunityIterator.
+ // TODO(layout-dev): Remove once NGConstraintSpaceBuilder exists.
NGConstraintSpace(const NGConstraintSpace& other,
NGLogicalOffset,
NGLogicalSize);
@@ -52,6 +49,7 @@ class CORE_EXPORT NGConstraintSpace final
// input constraint space, but has a different container size, writing mode
// and direction. Sets the offset to zero. For use by layout algorithms
// to use as the basis to find layout opportunities for children.
+ // TODO(layout-dev): Remove once NGConstraintSpaceBuilder exists.
NGConstraintSpace(NGWritingMode,
NGDirection,
const NGConstraintSpace& other,
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_box.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698