Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 244183002: Add ClassDeclaration/ClassTypeAlias.isAbstract() and use them. (Closed)

Created:
6 years, 8 months ago by scheglov
Modified:
6 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add ClassDeclaration/ClassTypeAlias.isAbstract() and use them. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35195

Patch Set 1 #

Patch Set 2 : forgotten class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ClassDeclaration.java View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/ast/ClassTypeAlias.java View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/ClassDeclarationTest.java View 2 chunks +6 lines, -0 lines 0 comments Download
A + editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/ClassTypeAliasTest.java View 1 1 chunk +8 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java View 4 chunks +2 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/LightNodeElements.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/JUnitSemanticProcessor.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 8 months ago (2014-04-19 17:48:27 UTC) #1
Brian Wilkerson
LGTM
6 years, 8 months ago (2014-04-20 16:03:10 UTC) #2
scheglov
6 years, 8 months ago (2014-04-20 16:05:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698