editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java - Issue 244183002: Add ClassDeclaration/ClassTypeAlias.isAbstract() and use them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java

Issue 244183002: Add ClassDeclaration/ClassTypeAlias.isAbstract() and use them. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: forgotten class Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/ast/TestAll.java ('k') | editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/LightNodeElements.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java

diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java

index 3a59570db317e68833c9ec9f094f92e967f50c12..5c1dd714d506be4d05329c99dd19976a3a9ba5b9 100644

--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java

+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/local/computer/DartUnitOutlineComputer.java

@@ -153,7 +153,6 @@ public class DartUnitOutlineComputer {

ClassDeclaration classDeclaration) {

SimpleIdentifier nameNode = classDeclaration.getName();

String name = nameNode.getName();

- // TODO(scheglov) add ClassDeclaration.isAbstract()

OutlineImpl outline = new OutlineImpl(

unitOutline,

getSourceRegion(classDeclaration),

@@ -163,7 +162,7 @@ public class DartUnitOutlineComputer {

name.length(),

null,

- classDeclaration.getAbstractKeyword() != null,

+ classDeclaration.isAbstract(),

false);

unitChildren.add(outline);

return outline;

@@ -172,7 +171,6 @@ public class DartUnitOutlineComputer {

private void newClassTypeAlias(Outline unitOutline, List<Outline> unitChildren,

ClassTypeAlias alias) {

SimpleIdentifier nameNode = alias.getName();

- // TODO(scheglov) add ClassTypeAlias.isAbstract()

unitChildren.add(new OutlineImpl(

unitOutline,

getSourceRegion(alias),

@@ -182,7 +180,7 @@ public class DartUnitOutlineComputer {

nameNode.getLength(),

null,

- alias.getAbstractKeyword() != null,

+ alias.isAbstract(),

false));

}