Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2440673002: [NTP Client] Put dismissing sections behind a flag (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Put dismissing sections behind a flag Dismissing status cards (and sections) now requires the NTPSuggestionsSectionDismissal feature to be enabled. Dismissing the Sign In promo is still possible. BUG=657494 Committed: https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378 Cr-Commit-Position: refs/heads/master@{#426457}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
dgn
PTAL
4 years, 2 months ago (2016-10-20 10:14:20 UTC) #4
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-20 12:22:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2440673002/1
4 years, 2 months ago (2016-10-20 12:31:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 12:40:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb75020ad83b3133a4e08cbec2b01f0dff44f378
Cr-Commit-Position: refs/heads/master@{#426457}

Powered by Google App Engine
This is Rietveld 408576698