chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java - Issue 2440673002: [NTP Client] Put dismissing sections behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2440673002: [NTP Client] Put dismissing sections behind a flag (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

index d9903b5a3df9f488ee3ea63a63bb86d157c8239b..2118ea8bd45d13e42d4ea35e967f6c514138374d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

@@ -170,6 +170,11 @@ public void updateLayoutParams() {

getParams().topMargin = 0;

}

+ @Override

+ public boolean isDismissable() {

+ return true;

+ }

}

private void checkIndex(int position) {