chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java - Issue 2440673002: [NTP Client] Put dismissing sections behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2440673002: [NTP Client] Put dismissing sections behind a flag (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

index 08cf25e9bfdd0f0151e27e003a0df1a928c58f6c..917295c631ee6e164d2a75397ef2f2c9ce766cb5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

@@ -9,6 +9,7 @@

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;

import org.chromium.chrome.browser.ntp.UiConfig;

+import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;

/**

* Item that allows the user to perform an action on the NTP.

@@ -75,7 +76,7 @@ public void onImpression() {

@Override

public boolean isDismissable() {

- return mActionListItem.mDismissable;

+ return SnippetsConfig.isSectionDismissalEnabled() && mActionListItem.mDismissable;

}

public void onBindViewHolder(ActionItem item) {