CoreAnimation: Reduce VA usage by extra layers

CoreAnimation: Reduce VA usage by extra layers

Use a solid color layer for TabContentsContainerView instead of using
drawRect. This prevents a backing store from being allocated.

Disable display updates when handling tab drags, to prevent the
background view from flashing.

BUG=364808
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264953

[ccameron, 2014-04-19 02:45:28]

Turns out that this view did need to be changed to a layer.

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm (right):

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm:148: 
[NSColor CGColor] is a 10.8+ function.

Not sure if a helper function is preferred or not (not for this change, cause it
needs to be merged, but I can add a TODO & do it after).

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm (right):

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm:117: 
The dark background was popping through without this -- it turns out that this
fixes a lot of flickering issues during tab drag.

[Avi (use Gerrit), 2014-04-19 19:30:49]

LGTM with nits.

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm (right):

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm:148: 
On 2014/04/19 02:45:29, ccameron1 wrote:
> [NSColor CGColor] is a 10.8+ function.
> 
> Not sure if a helper function is preferred or not (not for this change, cause
it
> needs to be merged, but I can add a TODO & do it after).

That's fine. With 10.6, they changed things so that you could assign an NSImage
for a layer's image, so I'm a bit surprised that you can't assign an NSColor
here and have it work.

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm:156: CGColorRef
cgBackgroundColor = CGColorCreate(cgColorSpace, components);
ScopedCFObject if you must go this route.

[ccameron, 2014-04-19 22:21:39]

Thanks!

Also updated to be white by default, unless we're in fullscreen-capture mode
(this was the behavior before, when the FastResizeView was the only one
visible).

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm (right):

https://codereview.chromium.org/244043002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm:156: CGColorRef
cgBackgroundColor = CGColorCreate(cgColorSpace, components);
On 2014/04/19 19:30:49, Avi wrote:
> ScopedCFObject if you must go this route.

Done.

[ccameron, 2014-04-19 22:22:38]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-04-19 22:22:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/244043002/80001

[commit-bot: I haz the power, 2014-04-20 22:20:20]

Change committed as 264953