Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2439663002: Return "auto" for computed z-index on non-stacking-context element (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return "auto" for computed z-index on non-stacking-context element Following https://codereview.chromium.org/2047283002 we were returning "0" for getComputedStyle(element).zIndex for elements that were not stacking contexts. Previously we would return "auto". Both behaviours are incorrect. This patch reverts the change in getComputedStyle() behaviour back to "auto". BUG=656681 Committed: https://crrev.com/664d4716b91e01c779a77702e9f219c2744724e0 Cr-Commit-Position: refs/heads/master@{#426690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-10-20 03:28:23 UTC) #4
rune
lgtm
4 years, 2 months ago (2016-10-20 07:25:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2439663002/1
4 years, 2 months ago (2016-10-21 02:06:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 02:19:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:26:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/664d4716b91e01c779a77702e9f219c2744724e0
Cr-Commit-Position: refs/heads/master@{#426690}

Powered by Google App Engine
This is Rietveld 408576698