Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1876)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2439663002: Return "auto" for computed z-index on non-stacking-context element (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Zack Rusin <zack@kde.org> 2 * Copyright (C) 2004 Zack Rusin <zack@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 5 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 6 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
7 * Copyright (C) 2011 Sencha, Inc. All rights reserved. 7 * Copyright (C) 2011 Sencha, Inc. All rights reserved.
8 * Copyright (C) 2015 Google Inc. All rights reserved. 8 * Copyright (C) 2015 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2815 matching lines...) Expand 10 before | Expand all | Expand 10 after
2826 case CSSPropertyWebkitFontSmoothing: 2826 case CSSPropertyWebkitFontSmoothing:
2827 return CSSIdentifierValue::create( 2827 return CSSIdentifierValue::create(
2828 style.getFontDescription().fontSmoothing()); 2828 style.getFontDescription().fontSmoothing());
2829 case CSSPropertyFontVariantLigatures: 2829 case CSSPropertyFontVariantLigatures:
2830 return valueForFontVariantLigatures(style); 2830 return valueForFontVariantLigatures(style);
2831 case CSSPropertyFontVariantCaps: 2831 case CSSPropertyFontVariantCaps:
2832 return valueForFontVariantCaps(style); 2832 return valueForFontVariantCaps(style);
2833 case CSSPropertyFontVariantNumeric: 2833 case CSSPropertyFontVariantNumeric:
2834 return valueForFontVariantNumeric(style); 2834 return valueForFontVariantNumeric(style);
2835 case CSSPropertyZIndex: 2835 case CSSPropertyZIndex:
2836 if (style.hasAutoZIndex()) 2836 if (style.hasAutoZIndex() || !style.isStackingContext())
2837 return CSSIdentifierValue::create(CSSValueAuto); 2837 return CSSIdentifierValue::create(CSSValueAuto);
2838 return CSSPrimitiveValue::create(style.zIndex(), 2838 return CSSPrimitiveValue::create(style.zIndex(),
2839 CSSPrimitiveValue::UnitType::Integer); 2839 CSSPrimitiveValue::UnitType::Integer);
2840 case CSSPropertyZoom: 2840 case CSSPropertyZoom:
2841 return CSSPrimitiveValue::create(style.zoom(), 2841 return CSSPrimitiveValue::create(style.zoom(),
2842 CSSPrimitiveValue::UnitType::Number); 2842 CSSPrimitiveValue::UnitType::Number);
2843 case CSSPropertyBoxSizing: 2843 case CSSPropertyBoxSizing:
2844 if (style.boxSizing() == BoxSizingContentBox) 2844 if (style.boxSizing() == BoxSizingContentBox)
2845 return CSSIdentifierValue::create(CSSValueContentBox); 2845 return CSSIdentifierValue::create(CSSValueContentBox);
2846 return CSSIdentifierValue::create(CSSValueBorderBox); 2846 return CSSIdentifierValue::create(CSSValueBorderBox);
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
3613 case CSSPropertyAll: 3613 case CSSPropertyAll:
3614 return nullptr; 3614 return nullptr;
3615 default: 3615 default:
3616 break; 3616 break;
3617 } 3617 }
3618 ASSERT_NOT_REACHED(); 3618 ASSERT_NOT_REACHED();
3619 return nullptr; 3619 return nullptr;
3620 } 3620 }
3621 3621
3622 } // namespace blink 3622 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698