third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2439663002: Return "auto" for computed z-index on non-stacking-context element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2439663002: Return "auto" for computed z-index on non-stacking-context element (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index b80fcb869d8d85f524fc2adb4951684aea6834b0..2d99858cd70a50d93294295a234d955d2b1dbba6 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2833,7 +2833,7 @@ const CSSValue* ComputedStyleCSSValueMapping::get(

case CSSPropertyFontVariantNumeric:

return valueForFontVariantNumeric(style);

case CSSPropertyZIndex:

- if (style.hasAutoZIndex())

+ if (style.hasAutoZIndex() || !style.isStackingContext())

return CSSIdentifierValue::create(CSSValueAuto);

return CSSPrimitiveValue::create(style.zIndex(),

CSSPrimitiveValue::UnitType::Integer);

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/getComputedStyle/getComputedStyle-zIndex-non-auto-expected.txt ('k') | no next file » | no next file with comments »