Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2438433006: chrome: change ProfileErrorType enum into an enum class (Closed)

Created:
4 years, 2 months ago by tfarina
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, browser-components-watch_chromium.org, WC Leung
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: change ProfileErrorType enum into an enum class See http://www.stroustrup.com/C++11FAQ.html#enum to see why enum class is preferred over traditional enums. BUG=621555 R=thestig@chromium.org Committed: https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353 Cr-Commit-Position: refs/heads/master@{#426682}

Patch Set 1 #

Patch Set 2 : fix compilation error #

Total comments: 2

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/history/chrome_history_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/profile_error_dialog.h View 1 2 1 chunk +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/profile_error_dialog.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/web_data_service_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tfarina
4 years, 2 months ago (2016-10-20 12:38:50 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/2438433006/diff/10001/chrome/browser/ui/profile_error_dialog.h File chrome/browser/ui/profile_error_dialog.h (right): https://codereview.chromium.org/2438433006/diff/10001/chrome/browser/ui/profile_error_dialog.h#newcode12 chrome/browser/ui/profile_error_dialog.h:12: // PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last ...
4 years, 2 months ago (2016-10-20 21:47:23 UTC) #6
tfarina
https://codereview.chromium.org/2438433006/diff/10001/chrome/browser/ui/profile_error_dialog.h File chrome/browser/ui/profile_error_dialog.h (right): https://codereview.chromium.org/2438433006/diff/10001/chrome/browser/ui/profile_error_dialog.h#newcode12 chrome/browser/ui/profile_error_dialog.h:12: // PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element ...
4 years, 2 months ago (2016-10-20 23:38:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438433006/30001
4 years, 2 months ago (2016-10-20 23:38:49 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 2 months ago (2016-10-21 01:35:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:25:52 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87b7a3fcc1bce355eae717c60c35309dcb0b8353
Cr-Commit-Position: refs/heads/master@{#426682}

Powered by Google App Engine
This is Rietveld 408576698