Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: chrome/browser/ui/profile_error_dialog.h

Issue 2438433006: chrome: change ProfileErrorType enum into an enum class (Closed)
Patch Set: update comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/profile_error_dialog.h
diff --git a/chrome/browser/ui/profile_error_dialog.h b/chrome/browser/ui/profile_error_dialog.h
index a3d325fa5e24e82a41035abab1517357a538e746..0c552a788796685610d7c4b62cc5bda048fdf00a 100644
--- a/chrome/browser/ui/profile_error_dialog.h
+++ b/chrome/browser/ui/profile_error_dialog.h
@@ -8,21 +8,20 @@
#include <string>
// Be very careful while modifying this enum. Do NOT remove any elements from
-// this enum. If you need to add one, add them to the end, right before
-// PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element in
-// this enum. This is important because this enum is used to back a histogram,
-// and these are implicit assumptions made in terms of how enumerated
-// histograms are defined.
-enum ProfileErrorType {
- PROFILE_ERROR_HISTORY,
- PROFILE_ERROR_PREFERENCES,
- PROFILE_ERROR_DB_AUTOFILL_WEB_DATA,
- PROFILE_ERROR_DB_TOKEN_WEB_DATA,
- PROFILE_ERROR_DB_WEB_DATA,
- PROFILE_ERROR_DB_KEYWORD_WEB_DATA,
- PROFILE_ERROR_CREATE_FAILURE_SPECIFIED,
- PROFILE_ERROR_CREATE_FAILURE_ALL,
- PROFILE_ERROR_END
+// this enum. If you need to add one, add them to the end, right before END.
+// END should ALWAYS be the last element in this enum. This is important because
+// this enum is used to back a histogram, and these are implicit assumptions
+// made in terms of how enumerated histograms are defined.
+enum class ProfileErrorType {
+ HISTORY,
+ PREFERENCES,
+ DB_AUTOFILL_WEB_DATA,
+ DB_TOKEN_WEB_DATA,
+ DB_WEB_DATA,
+ DB_KEYWORD_WEB_DATA,
+ CREATE_FAILURE_SPECIFIED,
+ CREATE_FAILURE_ALL,
+ END
};
// Shows an error dialog corresponding to the inability to open some portion of
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698