Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/ui/profile_error_dialog.h

Issue 2438433006: chrome: change ProfileErrorType enum into an enum class (Closed)
Patch Set: update comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
6 #define CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 6 #define CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 // Be very careful while modifying this enum. Do NOT remove any elements from 10 // Be very careful while modifying this enum. Do NOT remove any elements from
11 // this enum. If you need to add one, add them to the end, right before 11 // this enum. If you need to add one, add them to the end, right before END.
12 // PROFILE_ERROR_END. PROFILE_ERROR_END should ALWAYS be the last element in 12 // END should ALWAYS be the last element in this enum. This is important because
13 // this enum. This is important because this enum is used to back a histogram, 13 // this enum is used to back a histogram, and these are implicit assumptions
14 // and these are implicit assumptions made in terms of how enumerated 14 // made in terms of how enumerated histograms are defined.
15 // histograms are defined. 15 enum class ProfileErrorType {
16 enum ProfileErrorType { 16 HISTORY,
17 PROFILE_ERROR_HISTORY, 17 PREFERENCES,
18 PROFILE_ERROR_PREFERENCES, 18 DB_AUTOFILL_WEB_DATA,
19 PROFILE_ERROR_DB_AUTOFILL_WEB_DATA, 19 DB_TOKEN_WEB_DATA,
20 PROFILE_ERROR_DB_TOKEN_WEB_DATA, 20 DB_WEB_DATA,
21 PROFILE_ERROR_DB_WEB_DATA, 21 DB_KEYWORD_WEB_DATA,
22 PROFILE_ERROR_DB_KEYWORD_WEB_DATA, 22 CREATE_FAILURE_SPECIFIED,
23 PROFILE_ERROR_CREATE_FAILURE_SPECIFIED, 23 CREATE_FAILURE_ALL,
24 PROFILE_ERROR_CREATE_FAILURE_ALL, 24 END
25 PROFILE_ERROR_END
26 }; 25 };
27 26
28 // Shows an error dialog corresponding to the inability to open some portion of 27 // Shows an error dialog corresponding to the inability to open some portion of
29 // the profile. 28 // the profile.
30 // The ProfileErrorType |type| needs to correspond to one of the profile error 29 // The ProfileErrorType |type| needs to correspond to one of the profile error
31 // types in the enum above. If your use case doesn't fit any of the ones listed 30 // types in the enum above. If your use case doesn't fit any of the ones listed
32 // above, please add your type to the enum and modify the enum definition in 31 // above, please add your type to the enum and modify the enum definition in
33 // tools/metrics/histograms/histograms.xml accordingly. 32 // tools/metrics/histograms/histograms.xml accordingly.
34 // |message_id| is a string id corresponding to the message to show. 33 // |message_id| is a string id corresponding to the message to show.
35 // |diagnostics| contains diagnostic information about the database file that 34 // |diagnostics| contains diagnostic information about the database file that
36 // might have caused a profile error. 35 // might have caused a profile error.
37 void ShowProfileErrorDialog(ProfileErrorType type, 36 void ShowProfileErrorDialog(ProfileErrorType type,
38 int message_id, 37 int message_id,
39 const std::string& diagnostics); 38 const std::string& diagnostics);
40 39
41 #endif // CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_ 40 #endif // CHROME_BROWSER_UI_PROFILE_ERROR_DIALOG_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698