Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2438163002: Remove SpdyFramerVisitorInterface::OnControlFrameHeaderData(). (Closed)

Created:
4 years, 2 months ago by yasong
Modified:
4 years, 2 months ago
Reviewers:
Bence, yasong1
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SpdyFramerVisitorInterface::OnControlFrameHeaderData(). SpdyFramerVisitorInterface::OnControlFrameHeaderData() is never called, so all of its implementations (and related code) can be deleted. This CL lands server change 135920024 by birenroy. BUG=488484 Committed: https://crrev.com/73d2da9ae04cb72258a4c8cbac7a90a0677c1006 Cr-Commit-Position: refs/heads/master@{#426875}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -353 lines) Patch
M net/quic/core/quic_headers_stream.h View 3 chunks +3 lines, -13 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 4 chunks +3 lines, -60 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 3 chunks +1 line, -69 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_deframer_visitor.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M net/spdy/spdy_framer.h View 7 chunks +7 lines, -47 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M net/spdy/spdy_no_op_visitor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/spdy/spdy_no_op_visitor.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 1 2 2 chunks +0 lines, -18 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 12 chunks +24 lines, -29 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
yasong
On 2016/10/20 23:27:26, yasong wrote: > mailto:yasong@chromium.org changed reviewers: > + mailto:bnc@chromium.org Ready for review. ...
4 years, 2 months ago (2016-10-20 23:27:44 UTC) #7
Bence
On 2016/10/20 23:27:44, yasong wrote: > On 2016/10/20 23:27:26, yasong wrote: > > mailto:yasong@chromium.org changed ...
4 years, 2 months ago (2016-10-21 00:34:51 UTC) #9
Bence
LGTM.
4 years, 2 months ago (2016-10-21 20:00:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438163002/40001
4 years, 2 months ago (2016-10-21 20:02:40 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-21 20:26:03 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 20:27:39 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73d2da9ae04cb72258a4c8cbac7a90a0677c1006
Cr-Commit-Position: refs/heads/master@{#426875}

Powered by Google App Engine
This is Rietveld 408576698