Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: net/spdy/spdy_deframer_visitor.cc

Issue 2438163002: Remove SpdyFramerVisitorInterface::OnControlFrameHeaderData(). (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/mock_spdy_framer_visitor.h ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_deframer_visitor.cc
diff --git a/net/spdy/spdy_deframer_visitor.cc b/net/spdy/spdy_deframer_visitor.cc
index e99114fba71b6540d0eee3f83077a597e76bf9df..5b8535bd34389d6609e9a4d1d077676549dc2aeb 100644
--- a/net/spdy/spdy_deframer_visitor.cc
+++ b/net/spdy/spdy_deframer_visitor.cc
@@ -145,9 +145,6 @@ class SpdyTestDeframerImpl : public SpdyTestDeframer,
SpdyHeadersHandlerInterface* OnHeaderFrameStart(
SpdyStreamId stream_id) override;
void OnHeaderFrameEnd(SpdyStreamId stream_id, bool end_headers) override;
- bool OnControlFrameHeaderData(SpdyStreamId stream_id,
- const char* header_data,
- size_t header_data_len) override;
void OnDataFrameHeader(SpdyStreamId stream_id,
size_t length,
bool fin) override;
@@ -468,25 +465,6 @@ void SpdyTestDeframerImpl::OnContinuation(SpdyStreamId stream_id, bool end) {
end_ = end;
}
-// Called with the decompressed contents of headers, in zero or more pieces
-// (i.e. an empty headers frame doesn't have any non-zero length data).
-// Note that the end of the headers is indicated by header_data==nullptr
-// AND header_data_len==0, even if there were no non-zero pieces.
-// SpdyHeadersBlockParser decodes these.
-// Returning false kills the connection (SpdyFramer enters state SPDY_ERROR).
-bool SpdyTestDeframerImpl::OnControlFrameHeaderData(SpdyStreamId stream_id,
- const char* header_data,
- size_t header_data_len) {
- DVLOG(1) << "OnControlFrameHeaderData stream_id: " << stream_id
- << " len: " << header_data_len;
- CHECK(frame_type_ == HEADERS || frame_type_ == CONTINUATION ||
- frame_type_ == PUSH_PROMISE)
- << " frame_type_=" << Http2FrameTypeToString(frame_type_);
- CHECK_EQ(stream_id_, stream_id);
- LOG(FATAL) << "Must call SpdyFramer::set_use_new_methods_for_test(true)";
- return true;
-}
-
// Note that length includes the padding length (0 to 256, when the optional
// padding length field is counted). Padding comes after the payload, both
// for DATA frames and for control frames.
« no previous file with comments | « net/spdy/mock_spdy_framer_visitor.h ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698